From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] kvmctl.c: allow custom memory setup. Date: Thu, 18 Oct 2007 12:39:36 +0200 Message-ID: <471737E8.6000708@qumranet.com> References: <470C8D28.2060408@qumranet.com> <470F2806.8090902@redhat.com> <4710701C.2040200@qumranet.com> <47134476.1050609@redhat.com> <47134857.9030102@redhat.com> <1192446374.6578.0.camel@izike-woof.qumranet.com> <47134BC0.1000008@redhat.com> <1192447442.6911.5.camel@izike-woof.qumranet.com> <47135284.1060106@redhat.com> <4715DEFC.8010507@redhat.com> <471690D2.2060204@qumranet.com> <47170D95.1050603@redhat.com> <471714FC.6050703@qumranet.com> <47173300.70907@redhat.com> <1192703432.3175.18.camel@izike-woof.qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Gerd Hoffmann To: Izik Eidus Return-path: In-Reply-To: <1192703432.3175.18.camel-siXIhNkUrCXckEVJwWePHtCfPAL7FxvL@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Izik Eidus wrote: > On Thu, 2007-10-18 at 12:18 +0200, Gerd Hoffmann wrote: > >> Dor Laor wrote: >> >>> Gerd Hoffmann wrote: >>> >>>> I don't see how I can pass a pointer to kvm_create_userspace_memory() >>>> via kvm_create() without breaking the libkvm interface. There is no >>>> flags field or similar which could be used to signal "vm_mem is a valid >>>> pointer, please use that instead of mmap()'ing anonymous memory". >>>> >>> There is no need to keep binary compat to libkvm as long as it is linked >>> statically. >>> >> What about source compatibility? >> >> cheers, >> Gerd >> >> >> > anyone who use kvmctl, should not call kvm_create_userspace_memory > directly, > > instead should call kvm_create()... > > Why not have an API for creating memory slots? It allows much more flexibility and is more in line with what qemu wants. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/