Re: [patch] kvmctl.c: allow custom memory setup.

Gerd Hoffmann
2007-10-18T12:24:40Z

Hi,

> Break it. It has just one user, our qemu, which is included in the same
> package.

No, I'm hacking up one more user ;)

But maybe I'm better off shipping a private copy of kvmctl.c as long as
the library interface isn't finalized yet and subject to change.

>> Thats why I went the route to additionally split the job kvm_create()
>> does into multiple, individually callable pieces. So I can first create
>> the vm, then create my custom memory slots (instead of the standard
>> setup built by kvm_create_userspace_memory()), then create the vcpu.
>>
>
> That's exactly what's needed.
>
> The patch looks good, except that I wouldn't export
> kvm_create_default_phys_mem().

Fine with me. If you one uses the splitted versions, then for creating
a non-default memory layout, so there is no point in exporting that one.

Should I send an updated patch or do you just drop these lines when merging?

cheers,
Gerd