From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [PATCH 2/3] Split kvmctl for architectures Date: Thu, 18 Oct 2007 15:28:25 -0500 Message-ID: <4717C1E9.1050501@codemonkey.ws> References: <1192738258.12849.26.camel@thinkpad> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , kvm-ppc-devel To: jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <1192738258.12849.26.camel@thinkpad> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jerone Young wrote: > This patch splits kvmctl architecture specific declarations & > implementations into their own files & headers. Common interfaces are > kept in kvmctl.h, as well as the arch specific headers are included from > within kvmctl.h. This may or may not want to be changed. > > Also includes the having different main.c files for different > architectures (otherwise it's a lot of ifdefs). > > Signed-off-by: Christian Ehrhardt > Signed-off-by: Jerone Young > This patch is pretty hard to reasonably review since diff is so large. A quick glance suggests that there's a lot of code duplication between things like main-x86.c and main-ppc.c. Perhaps the common code could be unified? Regards, Anthony Liguori ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/