Re: [kvm-ppc-devel] [PATCH] Split kvm_vcpu to support new archs.

[Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>]

Hollis Blanchard wrote:
> I must be misunderstanding, because this seems completely backwards to
> me. With your nesting, any time architecture code wants to access
> architecture state (which is almost all the time), you'd *need*
> container_of:
> 
>         void arch_func(struct kvm_vcpu *vcpu) {
>                 struct arch_vcpu *arch = container_of(vcpu, arch_vcpu,
>                 arch);
>                 arch->gpr[3] = 0;
>         }
> 
> In contrast, my nesting proposal would look like this:
> 
>         void arch_func(struct kvm_vcpu *vcpu) {
>                 vcpu->arch.gpr[3] = 0;
>         }
> 
I'm with Hollis on this one. It looks clearly preferable to me.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/