From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [RFC] passthrough for configure options to qemu Date: Sun, 21 Oct 2007 13:25:34 +0200 Message-ID: <471B372E.2080807@qumranet.com> References: <20071019151940.GB15533@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Carlo Marcelo Arenas Belon Return-path: In-Reply-To: <20071019151940.GB15533@tapir> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carlo Marcelo Arenas Belon wrote: > The following patch Implement a configure passthrough for qemu and > migrate all current qemu specific configuration flags (enable-alsa, > disable-vnc-tls and disable-gcc-check) to use it. > > It leaves a description of the current flags (as used in kvm's configure) > as a reference but I'm not sure if that is the right approach since the > wording with the corresponding qemu flags is different and the list is > obviously never going to be all inclusive. > @@ -26,8 +24,10 @@ usage() { > --qemu-cc=CC specify compiler for qemu (must be gcc-3.x) > --qemu-cflags=CFLAGS CFLAGS to add to qemu configuration > --qemu-ldflags=LDFLAGS LDFLAGS to add to qemu configuration > - --enable-alsa enable alsa support for qemu > - --disable-vnc-tls disable vnc tls support for qemu > + > + Any additional option is given to qemu's configure verbatim, including: > + --enable-alsa enable alsa support > + --disable-vnc-tls disable vnc tls support > --disable-gcc-check don't insist on gcc-3.x > CAUTION: this will break running without kvm > Why not call qemu's ./configure to get the help text? > @@ -111,13 +102,10 @@ fi > --disable-kqemu --extra-cflags="-I $PWD/../user $qemu_cflags" \ > --extra-ldflags="-L $PWD/../user $qemu_ldflags" \ > --enable-kvm --kernel-path="$libkvm_kerneldir" \ > - ${enable_alsa:+"--enable-alsa"} \ > - ${disable_vnc_tls:+"--disable-vnc-tls"} \ > - ${disable_gcc_check:+"--disable-gcc-check"} \ > --prefix="$prefix" \ > ${qemu_cc:+"--cc=$qemu_cc"} \ > ${cross_prefix:+"--cross-prefix=$cross_prefix"} \ > - ${cross_prefix:+"--cpu=$arch"} > + ${cross_prefix:+"--cpu=$arch"} $qemu_conf > ) > Is it possible in case of a failure due to an unrecognized option to call out usage() instead of qemu's? -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/