From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm uses smp_call_function_mask() inkvm_flush_remote_tlbs() Date: Mon, 22 Oct 2007 17:11:45 +0200 Message-ID: <471CBDB1.5090509@qumranet.com> References: <11930635871488-git-send-email-Laurent.Vivier@bull.net> <471CBA60.2030402@qumranet.com> <471CBB70.5050109@bull.net> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Laurent Vivier Return-path: In-Reply-To: <471CBB70.5050109-6ktuUTfB/bM@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Laurent Vivier wrote: > Dor Laor a =E9crit : > = >> Laurent Vivier wrote: >> = >>> This patches can be applied only on kvm-updates-2.6.24 and = >>> kvm-updates-2.6.25 >>> as it needs smp_call_function_mask(). >>> >>> In kvm_flush_remote_tlbs(), it replaces a loop using = >>> smp_call_function_single() >>> by a single call to smp_call_function_mask(). >>> >>> = >> Would you be kind enough to copy the implementation of = >> smp_call_function_mask >> into external_module_compat.h so older kernel's will still work after = >> this commited. >> = > > Yes, I can, I think the best solution is to move the old KVM code using = > smp_function_call_single() to external_module_compat.h. > = Agree, s_c_f_m() is too low-level to go into e_m_c.h. -- = error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/