Re: [RFC] passthrough for configure options to qemu

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Carlo Marcelo Arenas Belon wrote:
> On Sun, Oct 21, 2007 at 01:25:34PM +0200, Avi Kivity wrote:
>   
>> Why not call qemu's ./configure to get the help text?
>>     
>
> can be done, I discarded it originally though as it seems pretty hacky as it 
> needs the list to be reformatted and filtered further as not all options are 
> relevant and some conflict with the ones that the final configure call for qemu
> is going to use, requiring assumptions about qemu which seem to defeat the
> principle of separation that a passthrough provides.
>
> if it wouldn't be that we rely in the --disable-gcc-check description to warn
> users that having kvm crash is expected if not using kvm, I'd say is probably
> better to remove all qemu options from kvm's configure usage() at all
>
>   


We can add a note at the end.  It doesn't have to be the ultimate in
typography, just usable.

>>> @@ -111,13 +102,10 @@ fi
>>>     --disable-kqemu --extra-cflags="-I $PWD/../user $qemu_cflags" \
>>>     --extra-ldflags="-L $PWD/../user $qemu_ldflags" \
>>>     --enable-kvm --kernel-path="$libkvm_kerneldir" \
>>> -    ${enable_alsa:+"--enable-alsa"} \
>>> -    ${disable_vnc_tls:+"--disable-vnc-tls"} \
>>> -    ${disable_gcc_check:+"--disable-gcc-check"} \
>>>     --prefix="$prefix" \
>>>     ${qemu_cc:+"--cc=$qemu_cc"} \
>>>     ${cross_prefix:+"--cross-prefix=$cross_prefix"} \
>>> -    ${cross_prefix:+"--cpu=$arch"}
>>> +    ${cross_prefix:+"--cpu=$arch"} $qemu_conf
>>> )
>>>       
>> Is it possible in case of a failure due to an unrecognized option to 
>> call out usage() instead of qemu's?
>>     
>
> not sure what you mean, but qemu's configure ignores any unrecognized options
> so it won't fail.
>   

That's a bug.  I'm sure qemu-devel would appreciate a patch.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/