[RFC] passthrough for configure options to qemu

[RFC] passthrough for configure options to qemu

[Carlo Marcelo Arenas Belon]

The following patch Implement a configure passthrough for qemu and 
migrate all current qemu specific configuration flags (enable-alsa, 
disable-vnc-tls and disable-gcc-check) to use it.

It leaves a description of the current flags (as used in kvm's configure)
as a reference but I'm not sure if that is the right approach since the
wording with the corresponding qemu flags is different and the list is
obviously never going to be all inclusive.

Signed-off-by: Carlo Marcelo Arenas Belon <carenas-kLeDWSohozoJb6fo7hG9ng@public.gmane.org>
---
 configure |   26 +++++++-------------------
 1 files changed, 7 insertions(+), 19 deletions(-)

diff --git a/configure b/configure
index a0c8746..e4ef880 100755
--- a/configure
+++ b/configure
@@ -6,9 +6,7 @@ want_module=1
 qemu_cc=
 qemu_cflags=
 qemu_ldflags=
-enable_alsa=
-disable_vnc_tls=
-disable_gcc_check=
+qemu_conf=
 cross_prefix=
 arch=`uname -m`
 target_exec=
@@ -26,8 +24,10 @@ usage() {
 	    --qemu-cc=CC           specify compiler for qemu (must be gcc-3.x)
 	    --qemu-cflags=CFLAGS   CFLAGS to add to qemu configuration
 	    --qemu-ldflags=LDFLAGS LDFLAGS to add to qemu configuration
-	    --enable-alsa          enable alsa support for qemu
-	    --disable-vnc-tls      disable vnc tls support for qemu
+
+	Any additional option is given to qemu's configure verbatim, including:
+	    --enable-alsa          enable alsa support
+	    --disable-vnc-tls      disable vnc tls support
 	    --disable-gcc-check    don't insist on gcc-3.x
 	                           CAUTION: this will break running without kvm
 EOF
@@ -60,15 +60,6 @@ while [[ "$1" = -* ]]; do
 	--qemu-ldflags)
 	    qemu_ldflags="$arg"
 	    ;;
-	--enable-alsa)
-	    enable_alsa=1
-	    ;;
-	--disable-vnc-tls)
-	    disable_vnc_tls=1
-	    ;;
-	--disable-gcc-check)
-	    disable_gcc_check=1
-	    ;;
 	--arch)
 	    arch="$arg"
 	    ;;
@@ -79,7 +70,7 @@ while [[ "$1" = -* ]]; do
 	    usage
 	    ;;
 	*)
-	    usage
+	    qemu_conf="$qemu_conf $opt"
 	    ;;
     esac
 done
@@ -111,13 +102,10 @@ fi
     --disable-kqemu --extra-cflags="-I $PWD/../user $qemu_cflags" \
     --extra-ldflags="-L $PWD/../user $qemu_ldflags" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
-    ${enable_alsa:+"--enable-alsa"} \
-    ${disable_vnc_tls:+"--disable-vnc-tls"} \
-    ${disable_gcc_check:+"--disable-gcc-check"} \
     --prefix="$prefix" \
     ${qemu_cc:+"--cc=$qemu_cc"} \
     ${cross_prefix:+"--cross-prefix=$cross_prefix"} \
-    ${cross_prefix:+"--cpu=$arch"}
+    ${cross_prefix:+"--cpu=$arch"} $qemu_conf
 )
 
 
-- 
1.5.2.5


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [RFC] passthrough for configure options to qemu

[Avi Kivity]

Carlo Marcelo Arenas Belon wrote:
> The following patch Implement a configure passthrough for qemu and 
> migrate all current qemu specific configuration flags (enable-alsa, 
> disable-vnc-tls and disable-gcc-check) to use it.
>
> It leaves a description of the current flags (as used in kvm's configure)
> as a reference but I'm not sure if that is the right approach since the
> wording with the corresponding qemu flags is different and the list is
> obviously never going to be all inclusive.
> @@ -26,8 +24,10 @@ usage() {
>  	    --qemu-cc=CC           specify compiler for qemu (must be gcc-3.x)
>  	    --qemu-cflags=CFLAGS   CFLAGS to add to qemu configuration
>  	    --qemu-ldflags=LDFLAGS LDFLAGS to add to qemu configuration
> -	    --enable-alsa          enable alsa support for qemu
> -	    --disable-vnc-tls      disable vnc tls support for qemu
> +
> +	Any additional option is given to qemu's configure verbatim, including:
> +	    --enable-alsa          enable alsa support
> +	    --disable-vnc-tls      disable vnc tls support
>  	    --disable-gcc-check    don't insist on gcc-3.x
>  	                           CAUTION: this will break running without kvm
>   

Why not call qemu's ./configure to get the help text?

> @@ -111,13 +102,10 @@ fi
>      --disable-kqemu --extra-cflags="-I $PWD/../user $qemu_cflags" \
>      --extra-ldflags="-L $PWD/../user $qemu_ldflags" \
>      --enable-kvm --kernel-path="$libkvm_kerneldir" \
> -    ${enable_alsa:+"--enable-alsa"} \
> -    ${disable_vnc_tls:+"--disable-vnc-tls"} \
> -    ${disable_gcc_check:+"--disable-gcc-check"} \
>      --prefix="$prefix" \
>      ${qemu_cc:+"--cc=$qemu_cc"} \
>      ${cross_prefix:+"--cross-prefix=$cross_prefix"} \
> -    ${cross_prefix:+"--cpu=$arch"}
> +    ${cross_prefix:+"--cpu=$arch"} $qemu_conf
>  )
>   


Is it possible in case of a failure due to an unrecognized option to 
call out usage() instead of qemu's?


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [RFC] passthrough for configure options to qemu

[Carlo Marcelo Arenas Belon]

On Sun, Oct 21, 2007 at 01:25:34PM +0200, Avi Kivity wrote:
>
> Why not call qemu's ./configure to get the help text?

can be done, I discarded it originally though as it seems pretty hacky as it 
needs the list to be reformatted and filtered further as not all options are 
relevant and some conflict with the ones that the final configure call for qemu
is going to use, requiring assumptions about qemu which seem to defeat the
principle of separation that a passthrough provides.

if it wouldn't be that we rely in the --disable-gcc-check description to warn
users that having kvm crash is expected if not using kvm, I'd say is probably
better to remove all qemu options from kvm's configure usage() at all

> >@@ -111,13 +102,10 @@ fi
> >     --disable-kqemu --extra-cflags="-I $PWD/../user $qemu_cflags" \
> >     --extra-ldflags="-L $PWD/../user $qemu_ldflags" \
> >     --enable-kvm --kernel-path="$libkvm_kerneldir" \
> >-    ${enable_alsa:+"--enable-alsa"} \
> >-    ${disable_vnc_tls:+"--disable-vnc-tls"} \
> >-    ${disable_gcc_check:+"--disable-gcc-check"} \
> >     --prefix="$prefix" \
> >     ${qemu_cc:+"--cc=$qemu_cc"} \
> >     ${cross_prefix:+"--cross-prefix=$cross_prefix"} \
> >-    ${cross_prefix:+"--cpu=$arch"}
> >+    ${cross_prefix:+"--cpu=$arch"} $qemu_conf
> > )
> 
> Is it possible in case of a failure due to an unrecognized option to 
> call out usage() instead of qemu's?

not sure what you mean, but qemu's configure ignores any unrecognized options
so it won't fail.

Carlo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [RFC] passthrough for configure options to qemu

[Avi Kivity]

Carlo Marcelo Arenas Belon wrote:
> On Sun, Oct 21, 2007 at 01:25:34PM +0200, Avi Kivity wrote:
>   
>> Why not call qemu's ./configure to get the help text?
>>     
>
> can be done, I discarded it originally though as it seems pretty hacky as it 
> needs the list to be reformatted and filtered further as not all options are 
> relevant and some conflict with the ones that the final configure call for qemu
> is going to use, requiring assumptions about qemu which seem to defeat the
> principle of separation that a passthrough provides.
>
> if it wouldn't be that we rely in the --disable-gcc-check description to warn
> users that having kvm crash is expected if not using kvm, I'd say is probably
> better to remove all qemu options from kvm's configure usage() at all
>
>   


We can add a note at the end.  It doesn't have to be the ultimate in
typography, just usable.

>>> @@ -111,13 +102,10 @@ fi
>>>     --disable-kqemu --extra-cflags="-I $PWD/../user $qemu_cflags" \
>>>     --extra-ldflags="-L $PWD/../user $qemu_ldflags" \
>>>     --enable-kvm --kernel-path="$libkvm_kerneldir" \
>>> -    ${enable_alsa:+"--enable-alsa"} \
>>> -    ${disable_vnc_tls:+"--disable-vnc-tls"} \
>>> -    ${disable_gcc_check:+"--disable-gcc-check"} \
>>>     --prefix="$prefix" \
>>>     ${qemu_cc:+"--cc=$qemu_cc"} \
>>>     ${cross_prefix:+"--cross-prefix=$cross_prefix"} \
>>> -    ${cross_prefix:+"--cpu=$arch"}
>>> +    ${cross_prefix:+"--cpu=$arch"} $qemu_conf
>>> )
>>>       
>> Is it possible in case of a failure due to an unrecognized option to 
>> call out usage() instead of qemu's?
>>     
>
> not sure what you mean, but qemu's configure ignores any unrecognized options
> so it won't fail.
>   

That's a bug.  I'm sure qemu-devel would appreciate a patch.


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [RFC] passthrough for configure options to qemu

[Carlo Marcelo Arenas Belon]

On Mon, Oct 22, 2007 at 09:51:24PM +0200, Avi Kivity wrote:
> Carlo Marcelo Arenas Belon wrote:
> > On Sun, Oct 21, 2007 at 01:25:34PM +0200, Avi Kivity wrote:
> >>>       
> >> Is it possible in case of a failure due to an unrecognized option to 
> >> call out usage() instead of qemu's?
> >
> > not sure what you mean, but qemu's configure ignores any unrecognized options
> > so it won't fail.
> >   
> 
> That's a bug.  I'm sure qemu-devel would appreciate a patch.

I think that was a feature instead, considering that there is almost no
implementation for reinforcing the defaults and so --disable-alsa (as an
example) will fail as an unknown option.

nevertheless will try to upstream the changes required

Carlo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/