Re: [RFT] kvm with Windows optimization

Avi Kivity
2007-10-25T19:01:34Z

Anthony Liguori wrote:
>>
>>> static int mmu_topup_memory_caches(struct kvm_vcpu *vcpu)
>>> {
>>> int r;
>>>
>>> kvm_mmu_free_some_pages(vcpu);
>>> r = mmu_topup_memory_cache(&vcpu->mmu_pte_chain_cache,
>>> pte_chain_cache, 4);
>>> if (r)
>>> goto out;
>>> r = mmu_topup_memory_cache(&vcpu->mmu_rmap_desc_cache,
>>> rmap_desc_cache, 1);
>>> if (r)
>>> goto out;
>>> r = mmu_topup_memory_cache_page(&vcpu->mmu_page_cache, 8);
>>> if (r)
>>> goto out;
>>> r = mmu_topup_memory_cache(&vcpu->mmu_page_header_cache,
>>> mmu_page_header_cache, 4);
>>> out:
>>> return r;
>>> }
>>
>>
>> These are the (4, 1, 8, 4) values in the call to
>> mmu_topup_memory_cache. Perhaps one of them is too low.
>
> Sure. Would this be affected at all by your tpr patch?

I believe not, but the code doesn't care what I believe.

> IIUC, if this is the problem, it should be reproducible with the
> latest git too?

One difference is that the tpr patch disables nx. That causes Windows
to go into 32-bit paging mode (nice that it has both pae and nonpae in
the same kernel), which may change things.

You can try booting your host with nx disabled to get the same effect
(or disable nx cpuid in kvm).

--
error compiling committee.c: too many arguments to function