From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [RFT] kvm with Windows optimization Date: Thu, 25 Oct 2007 18:31:20 -0500 Message-ID: <47212748.4070001@codemonkey.ws> References: <4720D122.4070606@qumranet.com> <4720D3F0.8010103@qumranet.com> <20071025200729.3f09d21d@holly> <4720DC12.8050303@qumranet.com> <4720DE65.2030209@qumranet.com> <4720E2AF.3070404@codemonkey.ws> <4720E53A.7040803@qumranet.com> <4720E65F.8070204@codemonkey.ws> <4720E80E.5070506@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------040805090808050703030308" Cc: Jindrich Makovicka , kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <4720E80E.5070506-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------040805090808050703030308 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Avi Kivity wrote: > Anthony Liguori wrote: >>> >>>> static int mmu_topup_memory_caches(struct kvm_vcpu *vcpu) >>>> { >>>> int r; >>>> >>>> kvm_mmu_free_some_pages(vcpu); >>>> r = mmu_topup_memory_cache(&vcpu->mmu_pte_chain_cache, >>>> pte_chain_cache, 4); >>>> if (r) >>>> goto out; >>>> r = mmu_topup_memory_cache(&vcpu->mmu_rmap_desc_cache, >>>> rmap_desc_cache, 1); >>>> if (r) >>>> goto out; >>>> r = mmu_topup_memory_cache_page(&vcpu->mmu_page_cache, 8); >>>> if (r) >>>> goto out; >>>> r = mmu_topup_memory_cache(&vcpu->mmu_page_header_cache, >>>> mmu_page_header_cache, 4); >>>> out: >>>> return r; >>>> } >>> >>> >>> These are the (4, 1, 8, 4) values in the call to >>> mmu_topup_memory_cache. Perhaps one of them is too low. >> >> Sure. Would this be affected at all by your tpr patch? Using the following patch, I'm getting really good results. I'll keep running test cases tonight and see if I can trigger anything. Windows is *much* faster with your patch, very nice work! Regards, Anthony Liguori --------------040805090808050703030308 Content-Type: text/x-patch; name="tpr-out-up-rmap_desc_cache.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="tpr-out-up-rmap_desc_cache.diff" Subject: [PATCH][TPR OPT] Increase rmap_desc_cache From: Anthony Liguori Cc: Avi Kivity Using kvm-test to replay the second stage of a WinXP Pro install, I can reliably trigger a BUG_ON() in the mmu. It usually happens during the first run. With this patch applied, I've been able to replay the install for the past few hours (probably 10 or so installs) without hitting the BUG_ON(). Signed-off-by: Anthony Liguori --- a/kernel/mmu.c 2007-10-25 12:36:18.000000000 -0500 +++ b/kernel/mmu.c 2007-10-25 17:09:55.000000000 -0500 @@ -280,7 +280,7 @@ if (r) goto out; r = mmu_topup_memory_cache(&vcpu->mmu_rmap_desc_cache, - rmap_desc_cache, 1); + rmap_desc_cache, 2); if (r) goto out; r = mmu_topup_memory_cache_page(&vcpu->mmu_page_cache, 8); --------------040805090808050703030308 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --------------040805090808050703030308 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------040805090808050703030308--