Re: [RFT] kvm with Windows optimization

Avi Kivity
2007-10-25T18:49:30Z

Anthony Liguori wrote:
> Avi Kivity wrote:
>> Haydn Solomon wrote:
>>
>>> I also had a problem installing windows xp. Got the following error
>>>
>>
>>
>> I guess I'll have to test that too.
>>
>
> I hit it again, this time about half-way through the second stage
> install of Windows XP (last time it was almost immediately). This is
> with your updated tree. I'll next try to reproduce with the latest git.

Can you try upping the 'min' parameter below:

> static int mmu_topup_memory_caches(struct kvm_vcpu *vcpu)
> {
> int r;
>
> kvm_mmu_free_some_pages(vcpu);
> r = mmu_topup_memory_cache(&vcpu->mmu_pte_chain_cache,
> pte_chain_cache, 4);
> if (r)
> goto out;
> r = mmu_topup_memory_cache(&vcpu->mmu_rmap_desc_cache,
> rmap_desc_cache, 1);
> if (r)
> goto out;
> r = mmu_topup_memory_cache_page(&vcpu->mmu_page_cache, 8);
> if (r)
> goto out;
> r = mmu_topup_memory_cache(&vcpu->mmu_page_header_cache,
> mmu_page_header_cache, 4);
> out:
> return r;
> }

These are the (4, 1, 8, 4) values in the call to
mmu_topup_memory_cache. Perhaps one of them is too low.

--
error compiling committee.c: too many arguments to function