Re: [RFT] kvm with Windows optimization

Anthony Liguori
2007-10-26T13:47:07Z

Avi Kivity wrote:
> Anthony Liguori wrote:
>> Avi Kivity wrote:
>>> Anthony Liguori wrote:
>>>>>
>>>>> Good movement!
>>>>>
>>>>> But, Vista won't work with patching. The memory guard in vista
>>>>> will make the system refuse to service. Maybe we need a option
>>>>> to check if it is vista.
>>>>>
>>>>
>>>> Are you sure that Vista isn't just verifying memory during
>>>> startup/driver load? Seems odd to periodically scan memory.
>>>>
>>>> In the recently released Windows Hypervisor specification, in
>>>> section 13.2.2 (Local APIC Memory-mapped Accesses), it's dictated
>>>> that the APIC can only be accessed through 6 instructions. They
>>>> are all >= 5 byte instructions. When I first saw that, I figured
>>>> they were also patching.
>>>>
>>>
>>> Six? My hack patches five. Which one did I miss?
>>
>> FF /6 PUSH m32
>>
>
> Thanks. That's easy to add.
>
>> Also note, that it says that all addresses are required to be 4-byte
>> aligned.
>
> Which addresses? The tpr address is obviously 4 byte aligned.

The tpr address.

Regards,

Anthony Liguori

> The instruction pointer?!