From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Subject: Re: [PATCH] raise tsc clocksource rating Date: Mon, 29 Oct 2007 17:17:54 -0700 Message-ID: <47267832.1060003@zytor.com> References: <11936994092607-git-send-email-gcosta@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: jeremy-TSDbQ3PG+2Y@public.gmane.org, avi-i/T1Zxg06OZWk0Htik3J/w@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Glauber de Oliveira Costa , --cc-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org To: Glauber de Oliveira Costa Return-path: In-Reply-To: <11936994092607-git-send-email-gcosta-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Glauber de Oliveira Costa wrote: > From: Glauber de Oliveira Costa > > tsc is very good time source (when it does not have drifts, does not > change it's frequency, i.e. when it works), so it should have its rating > raised to a value greater than, or equal 400. > > Since it's being a tendency among paravirt clocksources to use values > around 400, we should declare tsc as even better: So we use 500. > > This patch also touches the comments on clocksource.h, which suggests > that 499 would be a limit on the rating values. > > Signed-off-by: Glauber de Oliveira Costa Are you sure these paravirt sources don't intentionally trump the TSC? -hpa ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/