Re: [Patch] adding some scripts at installing

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Akio Takebe wrote:
> Hi,
>
>   

Hi,

> I wanted to use network with --mac optin of kvm script on guest,
> but I didn't use it because I didn't know needing to copy some scripts.
> I think it is better that we can use --mac option after "make install".
> So I modified install section in the Makefile.
>
> Signed-off-by: Akio Takebe <takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
>
> ---
>
> --- kvm-49/Makefile	2007-10-29 02:14:57.000000000 +0900
> +++ kvm-49.new/Makefile	2007-10-30 18:14:42.000000000 +0900
> @@ -43,6 +43,10 @@ install:
>  	$(kcmd)make -C kernel DESTDIR="$(DESTDIR)" install
>  	make -C user DESTDIR="$(DESTDIR)" install
>  	make -C qemu DESTDIR="$(DESTDIR)" install
> +	install -d $(DESTDIR)/$(confdir)
> +	cp scripts/kvm $(DESTDIR)/$(initdir)/kvm
> +	cp scripts/qemu-ifup $(DESTDIR)/$(confdir)/qemu-ifup
> +	install -t $(DESTDIR)/etc/udev/rules.d scripts/*kvm*.rules
>  
>  
>   

The kvm initscript is only suitable for Fedora systems, no?  I don't 
think it will run correctly on other distributions.

Installing the udev rule is a good idea, but is udev backwards 
compatible enough so that older distributions don't choke when they see 
the new rule?

Installing qemu-ifup is fine.

[personally I don't use the initscript, so it's probably outdated and a 
little broken.  I prefer to use Fedora's networking support for bridges 
instead of the initscript]

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/