[Patch] adding some scripts at installing

[Patch] adding some scripts at installing

[Akio Takebe]

Hi,

I wanted to use network with --mac optin of kvm script on guest,
but I didn't use it because I didn't know needing to copy some scripts.
I think it is better that we can use --mac option after "make install".
So I modified install section in the Makefile.

Signed-off-by: Akio Takebe <takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>

---

--- kvm-49/Makefile	2007-10-29 02:14:57.000000000 +0900
+++ kvm-49.new/Makefile	2007-10-30 18:14:42.000000000 +0900
@@ -43,6 +43,10 @@ install:
 	$(kcmd)make -C kernel DESTDIR="$(DESTDIR)" install
 	make -C user DESTDIR="$(DESTDIR)" install
 	make -C qemu DESTDIR="$(DESTDIR)" install
+	install -d $(DESTDIR)/$(confdir)
+	cp scripts/kvm $(DESTDIR)/$(initdir)/kvm
+	cp scripts/qemu-ifup $(DESTDIR)/$(confdir)/qemu-ifup
+	install -t $(DESTDIR)/etc/udev/rules.d scripts/*kvm*.rules
 
 tmpspec = .tmp.kvm.spec
 RPMDIR=$$(pwd)/RPMS

Best Regards,

Akio Takebe


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [Patch] adding some scripts at installing

[Alexey Eremenko]

[-- Attachment #1.1: Type: text/plain, Size: 975 bytes --]




-----Original Message-----
From: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org on behalf of Akio Takebe
Sent: Tue 10/30/2007 2:29 AM
To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: [kvm-devel] [Patch] adding some scripts at installing
 
Hi,

I wanted to use network with --mac optin of kvm script on guest,
but I didn't use it because I didn't know needing to copy some scripts.
I think it is better that we can use --mac option after "make install".
So I modified install section in the Makefile.

Signed-off-by: Akio Takebe <takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>

=========================================
Yes, that would be better.

However, I found that when using multiple virtual bridges (via brctl),
you need to have several script files.

In the future, I hope that bridging functionality could be integrated into Qemu/KVM, so that we won't need that script at all.

-Alexey

[-- Attachment #1.2: Type: text/html, Size: 1492 bytes --]

[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [Patch] adding some scripts at installing

[Akio Takebe]

Hi, Alexey

>Yes, that would be better.
>
>However, I found that when using multiple virtual bridges (via brctl),
>you need to have several script files.
>
Thank you for your comment.
Are there any other necessary files not including in my patch?
I may forgot some files because my machine is installed Xen.
If you found some of them, can you tell me them?

>In the future, I hope that bridging functionality could be integrated into 
>Qemu/KVM, so that we won't need that script at all.
>
It's nice. 

Best Regards,

Akio Takebe


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [Patch] adding some scripts at installing

[Avi Kivity]

Akio Takebe wrote:
> Hi,
>
>   

Hi,

> I wanted to use network with --mac optin of kvm script on guest,
> but I didn't use it because I didn't know needing to copy some scripts.
> I think it is better that we can use --mac option after "make install".
> So I modified install section in the Makefile.
>
> Signed-off-by: Akio Takebe <takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
>
> ---
>
> --- kvm-49/Makefile	2007-10-29 02:14:57.000000000 +0900
> +++ kvm-49.new/Makefile	2007-10-30 18:14:42.000000000 +0900
> @@ -43,6 +43,10 @@ install:
>  	$(kcmd)make -C kernel DESTDIR="$(DESTDIR)" install
>  	make -C user DESTDIR="$(DESTDIR)" install
>  	make -C qemu DESTDIR="$(DESTDIR)" install
> +	install -d $(DESTDIR)/$(confdir)
> +	cp scripts/kvm $(DESTDIR)/$(initdir)/kvm
> +	cp scripts/qemu-ifup $(DESTDIR)/$(confdir)/qemu-ifup
> +	install -t $(DESTDIR)/etc/udev/rules.d scripts/*kvm*.rules
>  
>  
>   

The kvm initscript is only suitable for Fedora systems, no?  I don't 
think it will run correctly on other distributions.

Installing the udev rule is a good idea, but is udev backwards 
compatible enough so that older distributions don't choke when they see 
the new rule?

Installing qemu-ifup is fine.

[personally I don't use the initscript, so it's probably outdated and a 
little broken.  I prefer to use Fedora's networking support for bridges 
instead of the initscript]

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/