From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Patch][RFC] fix make rpm Date: Tue, 30 Oct 2007 14:24:21 +0200 Message-ID: <47272275.7020703@qumranet.com> References: <47271CB2.1020503@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Akio Takebe Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Akio Takebe wrote: > Hi, Avi > > Thank you for your comments. > > > >>> This patch fix "make rpm". >>> When I used the rpm option, I got some error. >>> So I fixed it, but it is a just sample? >>> >>> >>> >> 'make rpm' works for me on F7 (after I fixed fallout from the libkvm >> separation patch). What distribution did you run it on? What error did >> you get? >> >> > I used RHEL5. I got the following error at fist. > > [root@vmx08 kvm-49]# make rpm > mkdir -p SOURCES SRPMS > mkdir: `SOURCES' exists but is not a directory > make: *** [srpm] Error 1 > [root@vmx08 kvm-49]# > Ah, SOURCES only exists in the distributed package, not in the git tree. That's why I never got an error. It's probably best to push all the rpm build directories under a new subdirectory rpm/. > So I retried it after remaking SOURCES. > > [root@vmx08 kvm-49]# rm SOURCES > rm: remove regular file `SOURCES'? yes > [root@vmx08 kvm-49]# mkdir SOURCES > [root@vmx08 kvm-49]# make rpm > mkdir -p SOURCES SRPMS > sed 's/^Release:.*/Release: devel/' kvm.spec > .tmp.kvm.spec > tar czf SOURCES/kvm.tar.gz qemu > tar czf SOURCES/user.tar.gz user > tar czf SOURCES/kernel.tar.gz kernel > tar czf SOURCES/scripts.tar.gz scripts > cp Makefile configure kvm_stat SOURCES > rpmbuild --define="_topdir $(pwd)" -bs .tmp.kvm.spec > error: types must match > error: /root/kvm-49/.tmp.kvm.spec:18: parseExpressionBoolean returns -1 > This can be fixed by updating the check on line 18 to include RHEL. We do need the BuildRequires below... > error: Package has no %description: kvm > make: *** [srpm] Error 1 > [root@vmx08 kvm-49]# > > After I fixed above, I got some more errors... > -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/