RFC/patch 0/3 portability: please review

RFC/patch 0/3 portability: please review

[Carsten Otte]

Thanks to Xiantao and Hollis for your quick review of last patch series.
Thanks Avi for finding time to pick up last patches on your trip to
Japan.

This series of patches moves more code from kvm_main.c to x86.c. I start
seeing the light at the end of the tunnel, I think these should be the
last big blocks that don't fit into kvm_main.c for s390. From here on, I
think I will use a much smaller hammer to get all the details right. :-)

Please review the patches to make sure nothing gets moved out that
should be common.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: RFC/patch 0/3 portability: please review

[Zhang, Xiantao]

Carsten Otte wrote:
> Thanks to Xiantao and Hollis for your quick review of last patch
> series. Thanks Avi for finding time to pick up last patches on your
> trip to Japan.
> 
> This series of patches moves more code from kvm_main.c to x86.c. I
> start seeing the light at the end of the tunnel, I think these should
> be the last big blocks that don't fit into kvm_main.c for s390. From
> here on, I think I will use a much smaller hammer to get all the
> details right. :-) 
> 
> Please review the patches to make sure nothing gets moved out that
> should be common.

Basically, It doesn't impact our side. For patch 2/3, we had better find
an approach to handle mmio-realted functions, becasue they may exist in
most archs. 
For IA64, if this move happens, we have to duplicate them in IA64 side.

Thanks 
Xiantao




>
------------------------------------------------------------------------
-
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a
> browser. Download your FREE copy of Splunk now >>
> http://get.splunk.com/ _______________________________________________
> kvm-devel mailing list
> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/kvm-devel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: RFC/patch 0/3 portability: please review

[Carsten Otte]

Zhang, Xiantao wrote:
> Basically, It doesn't impact our side. For patch 2/3, we had better find
> an approach to handle mmio-realted functions, becasue they may exist in
> most archs. 
> For IA64, if this move happens, we have to duplicate them in IA64 side.
Thanks for your feedback. This matches Hollis' view, I'll try to 
rework that patch. We're really the only platform without mmio, that's 
a s390 special case. I'll leave it in common and find a way around for 
s390.

cheers,
Carsten

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: RFC/patch 0/3 portability: please review

[Hollis Blanchard]

On Tue, 2007-10-30 at 22:53 +0100, Carsten Otte wrote:
> Zhang, Xiantao wrote:
> > Basically, It doesn't impact our side. For patch 2/3, we had better find
> > an approach to handle mmio-realted functions, becasue they may exist in
> > most archs. 
> > For IA64, if this move happens, we have to duplicate them in IA64 side.
> Thanks for your feedback. This matches Hollis' view, I'll try to 
> rework that patch. We're really the only platform without mmio, that's 
> a s390 special case. I'll leave it in common and find a way around for 
> s390.

Well, those functions right now are hacks that assume the only in-kernel
device is an APIC. That won't even build for anybody who doesn't have
vcpu->apic... that's why I say go ahead and move them, and we can worry
about it later.

-- 
Hollis Blanchard
IBM Linux Technology Center


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: RFC/patch 0/3 portability: please review

[Carsten Otte]

Hollis Blanchard wrote:
> On Tue, 2007-10-30 at 22:53 +0100, Carsten Otte wrote:
>> Zhang, Xiantao wrote:
>>> Basically, It doesn't impact our side. For patch 2/3, we had better find
>>> an approach to handle mmio-realted functions, becasue they may exist in
>>> most archs. 
>>> For IA64, if this move happens, we have to duplicate them in IA64 side.
>> Thanks for your feedback. This matches Hollis' view, I'll try to 
>> rework that patch. We're really the only platform without mmio, that's 
>> a s390 special case. I'll leave it in common and find a way around for 
>> s390.
> 
> Well, those functions right now are hacks that assume the only in-kernel
> device is an APIC. That won't even build for anybody who doesn't have
> vcpu->apic... that's why I say go ahead and move them, and we can worry
> about it later.
Right. Xiantao, does ia64 have an apic? Or do you intend to use the 
code different from x86?

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: RFC/patch 0/3 portability: please review

[Zhang, Xiantao]

Carsten Otte wrote:
> Hollis Blanchard wrote:
>> On Tue, 2007-10-30 at 22:53 +0100, Carsten Otte wrote:
>>> Zhang, Xiantao wrote:
>>>> Basically, It doesn't impact our side. For patch 2/3, we had
>>>> better find an approach to handle mmio-realted functions, becasue
>>>> they may exist in most archs. For IA64, if this move happens, we
>>>> have to duplicate them in IA64 side. 
>>> Thanks for your feedback. This matches Hollis' view, I'll try to
>>> rework that patch. We're really the only platform without mmio,
>>> that's a s390 special case. I'll leave it in common and find a way
>>> around for s390.
>> 
>> Well, those functions right now are hacks that assume the only
>> in-kernel device is an APIC. That won't even build for anybody who
>> doesn't have vcpu->apic... that's why I say go ahead and move them,
>> and we can worry about it later.
> Right. Xiantao, does ia64 have an apic? Or do you intend to use the
> code different from x86?

Yes, IA64 has sapic which has mostly same logic with apic. So, we can
reuse all ioapic code belongs to x86. I will find the approach to handle
it once IA64 code in.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: RFC/patch 0/3 portability: please review

[Zhang, Xiantao]

Hollis Blanchard wrote:
> On Tue, 2007-10-30 at 22:53 +0100, Carsten Otte wrote:
>> Zhang, Xiantao wrote:
>>> Basically, It doesn't impact our side. For patch 2/3, we had better
>>> find an approach to handle mmio-realted functions, becasue they may
>>> exist in most archs. For IA64, if this move happens, we have to
>>> duplicate them in IA64 side. 
>> Thanks for your feedback. This matches Hollis' view, I'll try to
>> rework that patch. We're really the only platform without mmio,
>> that's a s390 special case. I'll leave it in common and find a way
>> around for s390.
> 
> Well, those functions right now are hacks that assume the only
> in-kernel device is an APIC. That won't even build for anybody who
> doesn't have vcpu->apic... that's why I say go ahead and move them,
> and we can worry about it later.
IA64 has apic, and would reuse all ioapic code for in-kernel ioapic
emualtion. But for now, we can move it, and handle it later. :)

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: RFC/patch 0/3 portability: please review

[Avi Kivity]

Carsten Otte wrote:
> Thanks to Xiantao and Hollis for your quick review of last patch series.
> Thanks Avi for finding time to pick up last patches on your trip to
> Japan.
>
> This series of patches moves more code from kvm_main.c to x86.c. I start
> seeing the light at the end of the tunnel, I think these should be the
> last big blocks that don't fit into kvm_main.c for s390. From here on, I
> think I will use a much smaller hammer to get all the details right. :-)
>
>   

Thanks; all three applied.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/