public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [Patch][RFC] fix make rpm
Date: Wed, 31 Oct 2007 02:39:59 +0200	[thread overview]
Message-ID: <4727CEDF.8060304@qumranet.com> (raw)
In-Reply-To: <1193757041.12314.5.camel@basalt>

Hollis Blanchard wrote:
> On Tue, 2007-10-30 at 13:59 +0200, Avi Kivity wrote:
>   
>>> -/usr/kvm
>>> +%dir /usr/kvm
>>> +%dir /usr/kvm/bin
>>> +/usr/kvm/bin/qemu-img
>>> +/usr/kvm/bin/qemu-system-x86_64
>>>       
> [...]
>   
>> Why is this change necessary?  Doesn't '/usr/kvm' work?  This way,
>> every time qemu adds a file we have to update the rpm spec.
>>     
>
> FYI, I got burned by exactly this problem once. Due to a missing prereq,
> a package build didn't produce all the output it should have. However,
> because I hadn't listed every output explicitly, rpm happily packaged
> everything else, and the package shipped in a distro before anybody
> realized anything was missing.
>
>   

Yeah, perhaps the script should have a "dangerous" label.  Or all rpm 
scripts.

Listing the files doesn't actually solve the problem.  How does a 
packager know if a file was removed intenrionally or accidentally?

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

  reply	other threads:[~2007-10-31  0:39 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-30 10:15 [Patch][RFC] fix make rpm Akio Takebe
     [not found] ` <CBC81ADDCF7D33takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-30 11:59   ` Avi Kivity
     [not found]     ` <47271CB2.1020503-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-30 12:16       ` Akio Takebe
     [not found]         ` <CEC81AEEA48120takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org>
2007-10-30 12:24           ` Avi Kivity
2007-10-30 15:10       ` Hollis Blanchard
2007-10-31  0:39         ` Avi Kivity [this message]
     [not found]           ` <4727CEDF.8060304-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-10-31 15:25             ` Hollis Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4727CEDF.8060304@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox