[patch] (big) real mode emulation - mul instruction from group 3

[patch] (big) real mode emulation - mul instruction from group 3

[Nitin A Kamble]

[-- Attachment #1.1.1: Type: text/plain, Size: 321 bytes --]

Hi Avi,
 Attached is the patch to implement mul instruction from the group 3
opcodes.
  Please Apply.
-- 
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-----------------------------------------------------------------
The mind is like a parachute; it works much better when it's open

[-- Attachment #1.1.2: 0001-Implement-multipy-instruction-from-the-group-3.patch --]
[-- Type: application/mbox, Size: 862 bytes --]

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [patch] (big) real mode emulation - mul instruction from group 3

[Avi Kivity]

Nitin A Kamble wrote:
> Hi Avi,
>  Attached is the patch to implement mul instruction from the group 3
> opcodes.
>   
> diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c
> index 3959c20..5815128 100644
> --- a/drivers/kvm/x86_emulate.c
> +++ b/drivers/kvm/x86_emulate.c
> @@ -1034,6 +1034,8 @@ static inline int emulate_grp3(struct 
> x86_emulate_ctxt *ctxt,
>      case 3:    /* neg */
>          emulate_1op("neg", c->dst, ctxt->eflags);
>          break;
> +    case 4: /* mul */
> +        emulate_1op("mul", c->dst, ctxt->eflags);
>      default:
>          DPRINTF("Cannot emulate %02x\n", c->b);
>          rc = X86EMUL_UNHANDLEABLE;

This is missing a "break;".

How are you testing these patches?

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [patch] (big) real mode emulation - mul instruction from group 3

[Nitin A Kamble]

[-- Attachment #1.1: Type: text/plain, Size: 676 bytes --]

On Tue, 2007-10-30 at 17:53 -0700, Avi Kivity wrote:
> This is missing a "break;".
Hi Avi,
   You are right. The break statement should be there. It was my mistake
while getting the patch out from the test tree to the push tree. Even if
it is a small patch I should not retype it.

> 
> How are you testing these patches? 

I am running SL101 guest through my test tree. In my test tree the patch
is good, it was the bug introduced while copying.

-- 
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-----------------------------------------------------------------
The mind is like a parachute; it works much better when it's open

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel