From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [patch] (big) real mode emulation - mul instruction from group 3 Date: Wed, 31 Oct 2007 02:53:01 +0200 Message-ID: <4727D1ED.7070609@qumranet.com> References: <1193791027.9258.8.camel@lnitindesktop.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: nitin.a.kamble-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1193791027.9258.8.camel-mpPvwfgnXtFHIUuj5cj4Omt3HXsI98Cx0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Nitin A Kamble wrote: > Hi Avi, > Attached is the patch to implement mul instruction from the group 3 > opcodes. > > diff --git a/drivers/kvm/x86_emulate.c b/drivers/kvm/x86_emulate.c > index 3959c20..5815128 100644 > --- a/drivers/kvm/x86_emulate.c > +++ b/drivers/kvm/x86_emulate.c > @@ -1034,6 +1034,8 @@ static inline int emulate_grp3(struct > x86_emulate_ctxt *ctxt, > case 3: /* neg */ > emulate_1op("neg", c->dst, ctxt->eflags); > break; > + case 4: /* mul */ > + emulate_1op("mul", c->dst, ctxt->eflags); > default: > DPRINTF("Cannot emulate %02x\n", c->b); > rc = X86EMUL_UNHANDLEABLE; This is missing a "break;". How are you testing these patches? -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/