Re: [patch] (big) real mode emulation - mov rl/rh/r

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Nitin A Kamble wrote:
> Hi Avi,
>   Attached is the patch to implement emulation of instructions
>   mov rl, imm8 (opcodes 0xb0-0xb3)
>   mov rh, imm8 (opcodes 0xb4-0xb7)
>   mov r, imm (opcodes0xb8-0xbf)
>
>   
> @@ -146,8 +146,12 @@ static u16 opcode_table[256] = {
>         0, 0, ByteOp | ImplicitOps | Mov, ImplicitOps | Mov,
>         ByteOp | ImplicitOps | Mov, ImplicitOps | Mov,
>         ByteOp | ImplicitOps, ImplicitOps,
> -       /* 0xB0 - 0xBF */
> -       0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0,
> +       /* 0xB0 - 0xB7 */
> +       Mov | SrcImmByte, Mov | SrcImmByte, Mov | SrcImmByte, Mov | 
> SrcImmByte,
> +       Mov | SrcImmByte, Mov | SrcImmByte, Mov | SrcImmByte, Mov | 
> SrcImmByte,
> +       /* 0xB8 - 0xBF */
> +       Mov | SrcImm, Mov | SrcImm, Mov | SrcImm, Mov | SrcImm,
> +       Mov | SrcImm, Mov | SrcImm, Mov | SrcImm, Mov | SrcImm,
>         /* 0xC0 - 0xC7 */

Perhaps adding DstReg would reduce the decoding code later on?

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/