[patch] (big) real mode emulation - stc,cld

[patch] (big) real mode emulation - stc,cld

[Nitin A Kamble]

[-- Attachment #1.1.1: Type: text/plain, Size: 348 bytes --]

Hi Avi,
 Attached is the patch to implement emulation of instructions 

stc (opcode 0xf9) 
cld (opcode 0xfc)

Please Apply.

-- 
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-----------------------------------------------------------------
The mind is like a parachute; it works much better when it's open

[-- Attachment #1.1.2: 0006-Implement-emulation-of-instructions.patch --]
[-- Type: application/mbox, Size: 1713 bytes --]

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [patch] (big) real mode emulation - stc,cld

[Avi Kivity]

Nitin A Kamble wrote:
> Hi Avi,
>  Attached is the patch to implement emulation of instructions 
>
> stc (opcode 0xf9) 
> cld (opcode 0xfc)
>   
> +       case 0xfc: /* cld */
> +               ctxt->eflags |= X86_EFLAGS_DF;
> +               c->dst.type = OP_NONE;  /* Disable writeback. */
> +               break;
>         }

This is 'cld', but it looks like you're setting DF?

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [patch] (big) real mode emulation - stc,cld

[Nitin A Kamble]

[-- Attachment #1.1: Type: text/plain, Size: 477 bytes --]

On Tue, 2007-10-30 at 18:02 -0700, Avi Kivity wrote:
> This is 'cld', but it looks like you're setting DF?

Good catch. Same problem hand copy of the patch. 
It should look like this.
+       case 0xfc: /* cld */
+               ctxt->eflags &= ~EFLG_DF;
-- 
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-----------------------------------------------------------------
The mind is like a parachute; it works much better when it's open

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [patch] (big) real mode emulation - stc,cld

[Avi Kivity]

Nitin A Kamble wrote:
> On Tue, 2007-10-30 at 18:02 -0700, Avi Kivity wrote:
>   
>> This is 'cld', but it looks like you're setting DF?
>>     
>
> Good catch. Same problem hand copy of the patch. 
> It should look like this.
> +       case 0xfc: /* cld */
> +               ctxt->eflags &= ~EFLG_DF;
>   

'git gui' and 'git add -i' allow picking specific hunks out of a larger 
change.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [patch] (big) real mode emulation - stc,cld

[Nitin A Kamble]

[-- Attachment #1.1: Type: text/plain, Size: 445 bytes --]

On Wed, 2007-10-31 at 09:45 +0200, Avi Kivity wrote:
> 'git gui' and 'git add -i' allow picking specific hunks out of a
> larger change. 

This seems like better way of cutting patches. Thanks a lot for sharing
the trick.

-- 
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-----------------------------------------------------------------
The mind is like a parachute; it works much better when it's open

[-- Attachment #1.2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel