From mboxrd@z Thu Jan 1 00:00:00 1970 From: Izik Eidus Subject: Re: [PATCH 11 of 27] Move kvm_destroy_phys_mem to kvmctl-x86.c Date: Wed, 31 Oct 2007 23:11:12 +0200 Message-ID: <4728EF70.8050607@qumranet.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Jerone Young Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jerone Young wrote: > # HG changeset patch > # User Jerone Young > # Date 1193849564 18000 > # Node ID e2a804737e3b4847d7150dd5141e24a95460c46e > # Parent e0abf43119181082d46e21c02b07f275f08db02b > Move kvm_destroy_phys_mem to kvmctl-x86.c > > this is good that you removed it from kvcmtl, beacuse it use kvm_create_phys_mem, that have x86 depened stuff (for old kernel memory allocation support) , but we probably will want to keep the same function in kvmctl and just call it: with kvm_create_userspace_phys_mem (where len is zero) and change it name to kvm_destroy_userspace_mem or something like that, beside this i looked at your patch, and the logic seems good, all the functions that you removed as far as i can tell shouldnt be used by other archs ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/