Re: [PATCH] [RESEND] Move libkvm (v2)

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Cam Macdonell wrote:
>
> Hi Hollis and Avi,
>
> I run into a compile problem with libkvm when compiling kvm-49.   It 
> caused the compile problem mentioned in my email yesterday.
>
> It has to with the line in libkvm/Makefile
>
> CFLAGS += -I $(KERNELDIR)/include
>
> when compiling kvm-49 (git or snapshot), this include points to my 
> resident kernel's version of kvm.h instead of the local one copied 
> with "make sync LINUX=<kvm git repo>").
>
> in kvm-48, KERNELDIR points to the kvm-userspace/kernel/ directory 
> (under the git repo), but in the more recent versions it changes to 
> /lib/modules/2.6.22.9-61.fc6/build/include.
>
> Here are the compiles from kvm-48 (kvmctl.c) and 49 (libkvm.c) 
> respectively,
>
> kvm-48:
> gcc  -m64 -I /home/cam/research/KVM/Sakwatamau/kvm-48/kernel/include 
> -MMD -MF ./.kvmctl.d -g -fomit-frame-pointer -Wall  
> -fno-stack-protector     -c -o kvmctl.o kvmctl.c
>
> kvm-49:
> cc -MMD -MF ./.libkvm.d -g -fomit-frame-pointer -Wall 
> -fno-stack-protector   -I /lib/modules/2.6.22.9-61.fc6/build/include 
> -c -o libkvm.o libkvm.c
>
> what is KERNELDIR supposed to point to - the install location for the 
> modules or the location of kernel source?
>

I committed a patch from Uri that fixes this.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/