From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] [RESEND] Move libkvm (v2) Date: Thu, 01 Nov 2007 00:13:13 +0200 Message-ID: <4728FDF9.8060907@qumranet.com> References: <45227892356863ce29e9.1193719433@basalt> <4728A8C0.6030807@cs.ualberta.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Hollis Blanchard To: Cam Macdonell Return-path: In-Reply-To: <4728A8C0.6030807-edFDblaTWIyXbbII50Afww@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Cam Macdonell wrote: > > Hi Hollis and Avi, > > I run into a compile problem with libkvm when compiling kvm-49. It > caused the compile problem mentioned in my email yesterday. > > It has to with the line in libkvm/Makefile > > CFLAGS += -I $(KERNELDIR)/include > > when compiling kvm-49 (git or snapshot), this include points to my > resident kernel's version of kvm.h instead of the local one copied > with "make sync LINUX="). > > in kvm-48, KERNELDIR points to the kvm-userspace/kernel/ directory > (under the git repo), but in the more recent versions it changes to > /lib/modules/2.6.22.9-61.fc6/build/include. > > Here are the compiles from kvm-48 (kvmctl.c) and 49 (libkvm.c) > respectively, > > kvm-48: > gcc -m64 -I /home/cam/research/KVM/Sakwatamau/kvm-48/kernel/include > -MMD -MF ./.kvmctl.d -g -fomit-frame-pointer -Wall > -fno-stack-protector -c -o kvmctl.o kvmctl.c > > kvm-49: > cc -MMD -MF ./.libkvm.d -g -fomit-frame-pointer -Wall > -fno-stack-protector -I /lib/modules/2.6.22.9-61.fc6/build/include > -c -o libkvm.o libkvm.c > > what is KERNELDIR supposed to point to - the install location for the > modules or the location of kernel source? > I committed a patch from Uri that fixes this. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/