public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Hollis Blanchard <hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH 0 of 4] More x86 code movement
Date: Thu, 01 Nov 2007 15:08:03 +0200	[thread overview]
Message-ID: <4729CFB3.5070206@qumranet.com> (raw)
In-Reply-To: <patchbomb.1193869462@basalt>

Hollis Blanchard wrote:
> More straightforward code movement from kvm_main.c to x86.c.
> These patches have been build-tested on x86-32, but not run.
>
>   

Patches are good, but I get

> drivers/kvm/vmx.c: In function ‘vmx_vcpu_put’:
> drivers/kvm/vmx.c:534: error: implicit declaration of function 
> ‘kvm_put_guest_fpu’
> drivers/kvm/x86.c: In function ‘__vcpu_run’:
> drivers/kvm/x86.c:1852: error: implicit declaration of function 
> ‘kvm_load_guest_fpu’
> drivers/kvm/x86.c: At top level:
> drivers/kvm/x86.c:2306: warning: conflicting types for 
> ‘kvm_load_guest_fpu’
> drivers/kvm/x86.c:1852: warning: previous implicit declaration of 
> ‘kvm_load_guest_fpu’ was here

on x86_64.

The problem's only in the last patch, so I dropped it and applied the 
other three.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

  parent reply	other threads:[~2007-11-01 13:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-31 22:24 [PATCH 0 of 4] More x86 code movement Hollis Blanchard
2007-10-31 22:24 ` [PATCH 1 of 4] Make exported debugfs data architecture-specific Hollis Blanchard
2007-10-31 22:24 ` [PATCH 2 of 4] Move x86 instruction emulation code to x86.c Hollis Blanchard
2007-10-31 22:24 ` [PATCH 3 of 4] Move x86 FPU handling " Hollis Blanchard
2007-10-31 22:24 ` [PATCH 4 of 4] Move x86 vcpu ioctl handlers " Hollis Blanchard
2007-11-01 13:08 ` Avi Kivity [this message]
     [not found]   ` <4729CFB3.5070206-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-01 19:16     ` [PATCH] [v2] " Hollis Blanchard
2007-11-04  7:55       ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4729CFB3.5070206@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox