From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: removing kvm_init() Date: Sun, 04 Nov 2007 09:06:51 +0200 Message-ID: <472D6F8B.7090701@qumranet.com> References: <1193986584.24772.4.camel@diesel> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Hollis Blanchard Return-path: In-Reply-To: <1193986584.24772.4.camel@diesel> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > Hi Avi, I'm looking at kvm_init() right now. Since everything is driven > by the arch-specific modules (svm.c and vmx.c), I think it would > simplify things to fold all of kvm_init() into what is today called > kvm_init_x86(). > > If that's done, kvm_main.c won't have any "modinit" function, but I > think that would be OK since the init functionality will be executed as > needed by the arch modules. > > Does this make sense? > Yes, I think it simplifies things. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/