From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 00 of 27] Refactor libkvm code Phase 1 Date: Sun, 04 Nov 2007 09:40:34 +0200 Message-ID: <472D7772.9070907@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDC9040D8@pdsmsx415.ccr.corp.intel.com> <1193989780.7666.16.camel@thinkpad> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "Zhang, Xiantao" To: jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org Return-path: In-Reply-To: <1193989780.7666.16.camel@thinkpad> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jerone Young wrote: > Hmm, > The problem here is in the case of kvm_create_phys_mem & > kvm_create_default_phys_mem, most archs from now on should always be > allocating guest memory from userspace (at least I think this correct). > > Now if this is not the case then really adding an architecture hook > function to kvm_create_default_phys_mem would also solve this problem. > As There is a mmap call that maps memory for video(?), which is > something that is just for x86. > > With the size of these functions being very small, I think it's best to > move them for now. Then if someone else does need them they can easily > create there own and then we can figure out how to make a common > function in this case. > > Anyone disagree? > Me. Let's not copy and re-unify needlessly. If the create_kernel_memory() thing is a problem, define a function for non-x86 that returns -ENOSYS. It won't be called anyway. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/