From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Fix writing back APIC reset to inkernel APIC Date: Mon, 05 Nov 2007 16:03:15 +0200 Message-ID: <472F22A3.2030104@qumranet.com> References: <4729F257.30502@amd.com> <472A5AF4.9040900@qumranet.com> <10EA09EFD8728347A513008B6B0DA77A0250DC9B@pdsmsx411.ccr.corp.intel.com> <472D7993.8010802@qumranet.com> <10EA09EFD8728347A513008B6B0DA77A02557D4B@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Joerg.Roedel-5C7GfCeVMHo@public.gmane.org, Markus Rechberger To: "Dong, Eddie" Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A02557D4B-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Dong, Eddie wrote: > Avi Kivity wrote: > >> Dong, Eddie wrote: >> >>> Yes, when reseting, we need to reset both APIC/PIC/IOAPIC and pv >>> driver in future, and also VCPU. >>> But isn't apic_reset a pure user level APIC thing? >>> >> The reset callbacks are still called, so the userspace apic is >> still reset. >> > > OK. But since we have seperate kernel reset, doing double reset here > means > something weir to me. > > We can detect KVM_CAP_RESET and avoid it. > Maybe you just want to live with a pure apic reset only, then I am ok > too. > Once we established one ABI, probably we won't establish another set, do > we? > > No we have too many ABIs already. But userspace reset is via an existing ABI. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/