From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Starting a VM reboots my machine Date: Mon, 05 Nov 2007 16:25:00 +0200 Message-ID: <472F27BC.2060407@qumranet.com> References: <472A5561.5080202@cs.ualberta.ca> <64F9B87B6B770947A9F8391472E032160C95C59C@ehost011-8.exch011.intermedia.net> <20071104180538.GA6841@v2.random> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: Alexey Eremenko , kvm-devel To: Andrea Arcangeli Return-path: In-Reply-To: <20071104180538.GA6841-lysg2Xt5kKMAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Andrea Arcangeli wrote: > On Sun, Nov 04, 2007 at 08:15:26AM -0800, Alexey Eremenko wrote: > >> Cam: KVM-AMD is unstable now, unless you're a developer, I would suggest you to downgrade to KVM-36, which was the latest AMD-friendly version. We're working on a fix. >> >> Dor: kvm-amd crashes host, without leaving any netconsole messages. >> > > With x2 stepping G1 and with the below two fixes applied on top of kvm > and kvm-userland at least the host is certainly solid for me (the > opensuse 10.3 guest seems ok too). The x86 hack is mandatory with last > git kvm kernel, without it it's an immediate crash. > > Signed-off-by: Andrea Arcangeli > > diff --git a/kernel/Makefile b/kernel/Makefile > index b78c81a..68f6929 100644 > --- a/kernel/Makefile > +++ b/kernel/Makefile > @@ -32,6 +32,7 @@ sync: > $(call hack, mmu.c) > $(call hack, vmx.c) > $(call hack, svm.c) > + $(call hack, x86.c) > > install: > mkdir -p $(DESTDIR)/$(INSTALLDIR) > > > This one's obviously correct, will apply... > Signed-off-by: Andrea Arcangeli > > index 9584d0f..95a3489 100644 > --- a/drivers/kvm/svm.c > +++ b/drivers/kvm/svm.c > @@ -1459,11 +1459,6 @@ static void svm_vcpu_run(struct kvm_vcpu *vcpu, struct kvm_run *kvm_run) > > local_irq_enable(); > > - vcpu->guest_mode = 1; > - if (vcpu->requests) > - if (test_and_clear_bit(KVM_TLB_FLUSH, &vcpu->requests)) > - svm_flush_tlb(vcpu); > - > asm volatile ( > #ifdef CONFIG_X86_64 > "push %%rbp; \n\t" > > Against which kvm is that? It isn't 2.6.24-rc, or kvm.git, or 2.6.23? Anyway, removing guest tlb flushing won't be good for the guest. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/