Re: KVM-49 crash on XP(SP2) install

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

Avi Kivity wrote:
>
>> Code: 31 d9 31 f8 09 c1 74 2b 8b 0c 24 b8 01 00 00 00 31 db 89 86 74 
>> 0d 00 00 89
>> ea 89 f8 09 da 81 e1 01 08 00 00 09 c8 b9 80 00 00 c0 <0f> 30 ff 86 
>> b0 00 00 00
>> 8b 5c 24 08 8b 74 24 0c 8b 7c 24 10 8b
>> EIP: [<f8f99222>] vmx_save_host_state+0x132/0x190 [kvm_intel] SS:ESP
>>   
>
> Hmm, the EFER-less T2600 strikes again.  I'll prepare a patch.
>

Sorry, forgot about this, but a guilty conscience reminded me.  Does the 
attached patch help?


-- 
Any sufficiently difficult bug is indistinguishable from a feature.


[-- Attachment #2: no-efer-on-some-cpus.patch --]
[-- Type: text/x-patch, Size: 390 bytes --]

diff --git a/kernel/vmx.c b/kernel/vmx.c
index 42e7fad..f4cb3c1 100644
--- a/kernel/vmx.c
+++ b/kernel/vmx.c
@@ -370,6 +370,8 @@ static void load_transition_efer(struct vcpu_vmx *vmx)
 	u64 guest_efer = vmx->guest_msrs[efer_offset].data;
 	u64 ignore_bits;
 
+	if (efer_offset < 0)
+		return;
 	/*
 	 * NX is emulated; LMA and LME handled by hardware; SCE meaninless
 	 * outside long mode

[-- Attachment #3: Type: text/plain, Size: 314 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel