From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: KVM-49 crash on XP(SP2) install Date: Mon, 05 Nov 2007 17:47:28 +0200 Message-ID: <472F3B10.905@qumranet.com> References: <95c807760710301635t497f0e00y75350cfabf9fb907@mail.gmail.com> <4727DB3D.6050704@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------090700090607060309060202" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Tim Dempsey Return-path: In-Reply-To: <4727DB3D.6050704-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------090700090607060309060202 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Avi Kivity wrote: > >> Code: 31 d9 31 f8 09 c1 74 2b 8b 0c 24 b8 01 00 00 00 31 db 89 86 74 >> 0d 00 00 89 >> ea 89 f8 09 da 81 e1 01 08 00 00 09 c8 b9 80 00 00 c0 <0f> 30 ff 86 >> b0 00 00 00 >> 8b 5c 24 08 8b 74 24 0c 8b 7c 24 10 8b >> EIP: [] vmx_save_host_state+0x132/0x190 [kvm_intel] SS:ESP >> > > Hmm, the EFER-less T2600 strikes again. I'll prepare a patch. > Sorry, forgot about this, but a guilty conscience reminded me. Does the attached patch help? -- Any sufficiently difficult bug is indistinguishable from a feature. --------------090700090607060309060202 Content-Type: text/x-patch; name="no-efer-on-some-cpus.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="no-efer-on-some-cpus.patch" diff --git a/kernel/vmx.c b/kernel/vmx.c index 42e7fad..f4cb3c1 100644 --- a/kernel/vmx.c +++ b/kernel/vmx.c @@ -370,6 +370,8 @@ static void load_transition_efer(struct vcpu_vmx *vmx) u64 guest_efer = vmx->guest_msrs[efer_offset].data; u64 ignore_bits; + if (efer_offset < 0) + return; /* * NX is emulated; LMA and LME handled by hardware; SCE meaninless * outside long mode --------------090700090607060309060202 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --------------090700090607060309060202 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------090700090607060309060202--