From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Patch] improvement of "make rpm" Date: Tue, 06 Nov 2007 11:01:19 +0200 Message-ID: <47302D5F.9070801@qumranet.com> References: <4729C8FF.8020607@qumranet.com> <6C82012B93D81takebe_akio@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Akio Takebe Return-path: In-Reply-To: <6C82012B93D81takebe_akio-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Akio Takebe wrote: >>> >>> -%prep >>> +%if %([ x"%{Distribution}" = x"fedora" -a x"%{os_release}" = x"5" ] && >>> echo 1 | >>> | echo 0) >>> +%define fedora5 1 >>> +%endif >>> >>> >> Why not use regular rpm conditionals instead of calling the shell? >> >> > The regular rpm conditionals are poor facilities. > Shell has better parsing facilities. > The original checking fedora5 and centos4 doesn't work on RHEL5. > So I changed the checking with shell. > > Okay. >> Can you add an explicit test for RHEL 5? >> > OK, I'll add it. > Okay, thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/