From mboxrd@z Thu Jan  1 00:00:00 1970
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH 07 of 19] Move
	kvm_create_phys_mem	to	libkvm-x86.c
Date: Tue, 06 Nov 2007 11:10:22 +0200
Message-ID: <47302F7E.5090607@qumranet.com>
References: <8e77064ea82d0b7fbd8b.1194027896@thinkpad>	
	<472D74CB.8050602@qumranet.com> <1194297319.9355.10.camel@thinkpad>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
To: jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org
Return-path: <kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
In-Reply-To: <1194297319.9355.10.camel@thinkpad>
List-Unsubscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=unsubscribe>
List-Archive: <http://sourceforge.net/mailarchive/forum.php?forum_name=kvm-devel>
List-Post: <mailto:kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>
List-Help: <mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=help>
List-Subscribe: <https://lists.sourceforge.net/lists/listinfo/kvm-devel>,
	<mailto:kvm-devel-request-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org?subject=subscribe>
Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
List-Id: kvm.vger.kernel.org

Jerone Young wrote:
> On Sun, 2007-11-04 at 09:29 +0200, Avi Kivity wrote:
>   
>> Jerone Young wrote:
>>     
>>> # HG changeset patch
>>> # User Jerone Young <jyoung5-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
>>> # Date 1194027872 18000
>>> # Node ID 8e77064ea82d0b7fbd8bb77429bbfd62f99c00f6
>>> # Parent  02f38e54018070bafd501df846147f4ae7661109
>>> Move kvm_create_phys_mem to libkvm-x86.c
>>>
>>> This patch moves kvm_create_phys_mem to libkvm-x86.c
>>>
>>>   
>>>       
>> Creating physical memory isn't arch specific (though a few details 
>> are).  Why is this made arch specific?
>>     
>
> So these can be kept in the common place. 

No, you're moving the whole thing!

> But the fact is that x86 will
> be the only one to use them. 

What's "them" in this context?

> But technically anyone can potentially use
> it.  

And "it"?

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/