Re: [PATCH] Fix writing back APIC reset to inkernel APIC

Avi Kivity
2007-11-05T14:03:15Z

Dong, Eddie wrote:
> Avi Kivity wrote:
>
>> Dong, Eddie wrote:
>>
>>> Yes, when reseting, we need to reset both APIC/PIC/IOAPIC and pv
>>> driver in future, and also VCPU.
>>> But isn't apic_reset a pure user level APIC thing?
>>>
>> The reset callbacks are still called, so the userspace apic is
>> still reset.
>>
>
> OK. But since we have seperate kernel reset, doing double reset here
> means
> something weir to me.
>
>
We can detect KVM_CAP_RESET and avoid it.

> Maybe you just want to live with a pure apic reset only, then I am ok
> too.
> Once we established one ABI, probably we won't establish another set, do
> we?
>
>

No we have too many ABIs already. But userspace reset is via an
existing ABI.

--
Any sufficiently difficult bug is indistinguishable from a feature.