From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 11 of 17] Move msrs functions to libkvm-x86.c Date: Thu, 08 Nov 2007 07:54:54 +0200 Message-ID: <4732A4AE.30100@qumranet.com> References: <20071108055700.GA1937@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jerone Young To: Carlo Marcelo Arenas Belon Return-path: In-Reply-To: <20071108055700.GA1937@tapir> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carlo Marcelo Arenas Belon wrote: > On Tue, Nov 06, 2007 at 10:48:52AM -0600, Jerone Young wrote: > >> Move msrs functions to libkvm-x86.c >> >> This patch moves functions: >> kvm_msr_list >> move kvm_get_msrs >> move kvm_set_msrs >> > > the problem is that with this the definitions were moved as well from libkvm.h > to kvm-x86.h which is private and not meant to be exported outside of libkvm > but those 3 functions are used by qemu-kvm.c as shown by : > > They need to be moved back to libkvm.h with a #ifdef. And to the #ifdef purists I say: deorbit. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/