From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Amit Shah <amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] Add accessor for kvm->vm_fd
Date: Thu, 08 Nov 2007 08:43:51 +0200 [thread overview]
Message-ID: <4732B027.2040400@qumranet.com> (raw)
In-Reply-To: <200711081211.09455.amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Amit Shah wrote:
>>> Introduce kvm_get_vm_fd to get the VM FD
>>>
>> What, so you can issue ioctls like there's no tomorrow? Add function
>> wrappers for your ioctls instead.
>>
>
> Hmm. this might not be needed now since the kvm_context moved to a .h file. It
> was a static in a .c earlier.
>
That .h is not meant to be included by libkvm users.
--
Do not meddle in the internals of kernels, for they are subtle and quick to panic.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
prev parent reply other threads:[~2007-11-08 6:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-07 18:45 [PATCH] Add accessor for kvm->vm_fd Amit Shah
[not found] ` <200711080015.13694.amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-07 18:59 ` Amit Shah
[not found] ` <200711080029.05386.amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-08 6:26 ` Avi Kivity
[not found] ` <4732AC10.2030804-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-08 6:41 ` Amit Shah
[not found] ` <200711081211.09455.amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-08 6:43 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4732B027.2040400@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=amit.shah-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox