From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [PATCH] 4/5 Combine kvm_init and kvm_init_x86 intoonefunction (Correction V3) Date: Thu, 08 Nov 2007 14:55:10 +0100 Message-ID: <4733153E.7000100@de.ibm.com> References: <42DFA526FC41B1429CE7279EF83C6BDC90503A@pdsmsx415.ccr.corp.intel.com> <42DFA526FC41B1429CE7279EF83C6BDC905049@pdsmsx415.ccr.corp.intel.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, carsteno-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, Hollis Blanchard , Avi Kivity To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC905049-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org I agree with the gernal idea of this patch. Just a few minor things to pick on: Zhang, Xiantao wrote: > diff --git a/drivers/kvm/kvm.h b/drivers/kvm/kvm.h > index 4b2421a..33b4629 100644 > --- a/drivers/kvm/kvm.h > +++ b/drivers/kvm/kvm.h > @@ -494,9 +494,9 @@ void vcpu_load(struct kvm_vcpu *vcpu); > void vcpu_put(struct kvm_vcpu *vcpu); > > > -int kvm_init_x86(struct kvm_x86_ops *ops, unsigned int vcpu_size, > +int kvm_init(struct kvm_x86_ops *ops, unsigned int vcpu_size, > struct module *module); > -void kvm_exit_x86(void); > +void kvm_exit(void); Renaming this makes sense to me. > + r = kvm_mmu_module_init(); > + if (r) > + goto out4; This should go to kvm_arch_init. We don't want the shaddow-mmu module on s390. > + bad_page = alloc_page(GFP_KERNEL | __GFP_ZERO); > + > + if (bad_page == NULL) { > + r = -ENOMEM; > + goto out; > + } I don't think we need bad_page on s390, maybe I missed something. It's only useful for mmu code as far as I can tell. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/