From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 11 of 17] Move msrs functions to libkvm-x86.c Date: Sun, 11 Nov 2007 12:01:15 +0200 Message-ID: <4736D2EB.9000603@qumranet.com> References: <20071108055700.GA1937@tapir> <4732A4AE.30100@qumranet.com> <1194548392.22879.14.camel@basalt> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, kvm-ppc-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Jerone Young , Carlo Marcelo Arenas Belon To: Hollis Blanchard Return-path: In-Reply-To: <1194548392.22879.14.camel@basalt> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hollis Blanchard wrote: > On Thu, 2007-11-08 at 07:54 +0200, Avi Kivity wrote: > >> Carlo Marcelo Arenas Belon wrote: >> >>> On Tue, Nov 06, 2007 at 10:48:52AM -0600, Jerone Young wrote: >>> >>> >>>> Move msrs functions to libkvm-x86.c >>>> >>>> This patch moves functions: >>>> kvm_msr_list >>>> move kvm_get_msrs >>>> move kvm_set_msrs >>>> >>>> >>> the problem is that with this the definitions were moved as well from libkvm.h >>> to kvm-x86.h which is private and not meant to be exported outside of libkvm >>> but those 3 functions are used by qemu-kvm.c as shown by : >>> >>> >>> >> They need to be moved back to libkvm.h with a #ifdef. And to the #ifdef >> purists I say: deorbit. >> > > Re-entry is looking rough; things are much better up here. ;) > > Anyways, you don't need to ifdef a prototype; just don't call it. > See, that's what I meant: you're willing to turn a compile error into a link error just because you dislike #ifdefs. There are some things the preprocessor does well, there's no need to ban it just because it is often abused. > Also, naming them kvm_x86_get_msrs() and kvm_x86_set_msrs() would be a > much better warning sign for callers. > The rename makes sense, in addition to guarding the prototypes. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/