From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [ANNOUNCE] kvm-51 release Date: Mon, 12 Nov 2007 10:19:33 +0200 Message-ID: <47380C95.1030502@qumranet.com> References: <4731F5B5.1000108@qumranet.com> <473435B6.1000503@bppiac.hu> <4736C752.7060703@qumranet.com> <4736FC77.2080804@bppiac.hu> <47371510.3020804@qumranet.com> <47372070.30604@cisco.com> <47372600.9080009@cisco.com> <47373380.8040809@qumranet.com> <47376FB3.30303@cisco.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: david ahern Return-path: In-Reply-To: <47376FB3.30303-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org david ahern wrote: > The patch worked for me -- rhel4 smp guests boot fine on stock RHEL5 hosts, both 32-bit and 64-bit. > > Excellent. I had a premonition so it is already committed. Do note that smp_call_function_mask() emulation is pretty bad in terms of performance on large multicores. On a dual code it's basically equivalent to mainline, I guess it's okay for four-way, but above four-way you will need either mainline or a better smp_call_function_mask() (which is nontrivial but doable). > david > > > Avi Kivity wrote: > >> david ahern wrote: >> >>> In RHEL 5.1 defines: >>> >>> #define CPU_TASKS_FROZEN 0x0010 >>> >>> #define CPU_ONLINE_FROZEN (CPU_ONLINE | CPU_TASKS_FROZEN) >>> #define CPU_DEAD_FROZEN (CPU_DEAD | CPU_TASKS_FROZEN) >>> >>> which means in kvm-51/kernel/external-module-compat.h the '#ifndef >>> CPU_TASKS_FROZEN' needs to have a case. For my purposes, I just moved >>> up the endif around what was defined. >>> >>> >> I committed a change which renders this unnecessary. Will be part of >> kvm-52. >> >> >>> With that change, kvm-51 compiles. I am still seeing 32-bit SMP guests >>> hang on boot for both 32-bit and 64-bit hosts (again running RHEL5.1). >>> >>> >> I still don't. Can you test the attached patch? >> >> >> >> ------------------------------------------------------------------------ >> >> ------------------------------------------------------------------------- >> This SF.net email is sponsored by: Splunk Inc. >> Still grepping through log files to find problems? Stop. >> Now Search log events and configuration files using AJAX and a browser. >> Download your FREE copy of Splunk now >> http://get.splunk.com/ >> >> >> ------------------------------------------------------------------------ >> >> _______________________________________________ >> kvm-devel mailing list >> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org >> https://lists.sourceforge.net/lists/listinfo/kvm-devel >> -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/