Re: [PATCH] 5/5 Move-some-x86-specific-part-from-kvm_init-to-kvm_arch

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Zhang, Xiantao wrote:
> Carsten Otte wrote:
>   
>> I think two other functionalities need to be moved to kvm_arch_init
>> which are still in common: The call to kvm_mmu_set_nonpresent_ptes()
>> and the creation of kvm_vcpu_cache. This can well be done after
>> merging this patch. kvm_init looks very much cleaned up now, well done
>> Xiantao :-).
>>     
>
> Agree.  I am working on this now.  I think we should move all mmu code
> to arch specific.  
>
> Avi, 
> What's your ideas ? I rememberd you said we should keep some mmu
> interface in common, but seems current code is more x86-specific. Maybe
> we should move them into arch first. If other archs need them, we can
> move back and work out more generic interfaces.  At least, IA64 and S390
> doesn't need them:-)
>   

kvm_mmu_set_nonpresent_ptes() is very much arch specific.  It's okay by me to move things and move them back, so long that's the exception and not the rule.




-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/