From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] 5/5 Move-some-x86-specific-part-from-kvm_init-to-kvm_arch Date: Wed, 14 Nov 2007 15:37:52 +0200 Message-ID: <473AFA30.3040703@qumranet.com> References: <42DFA526FC41B1429CE7279EF83C6BDC94FACC@pdsmsx415.ccr.corp.intel.com> <473AE3E9.9020709@de.ibm.com> <42DFA526FC41B1429CE7279EF83C6BDC94FBF7@pdsmsx415.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org, kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Hollis Blanchard To: "Zhang, Xiantao" Return-path: In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC94FBF7-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Zhang, Xiantao wrote: > Carsten Otte wrote: > >> I think two other functionalities need to be moved to kvm_arch_init >> which are still in common: The call to kvm_mmu_set_nonpresent_ptes() >> and the creation of kvm_vcpu_cache. This can well be done after >> merging this patch. kvm_init looks very much cleaned up now, well done >> Xiantao :-). >> > > Agree. I am working on this now. I think we should move all mmu code > to arch specific. > > Avi, > What's your ideas ? I rememberd you said we should keep some mmu > interface in common, but seems current code is more x86-specific. Maybe > we should move them into arch first. If other archs need them, we can > move back and work out more generic interfaces. At least, IA64 and S390 > doesn't need them:-) > kvm_mmu_set_nonpresent_ptes() is very much arch specific. It's okay by me to move things and move them back, so long that's the exception and not the rule. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/