From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: "Zhang, Xiantao" <xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org,
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
Hollis Blanchard
<hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
Subject: Re: [PATCH] 3/5 Using kvm arch support instead of kvm_x86_ops
Date: Wed, 14 Nov 2007 17:25:28 +0200 [thread overview]
Message-ID: <473B1368.9000304@qumranet.com> (raw)
In-Reply-To: <42DFA526FC41B1429CE7279EF83C6BDC94FC27-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
Zhang, Xiantao wrote:
> Avi Kivity wrote:
>
>> Carsten Otte wrote:
>>
>>> I still do strongly agree with the general idea of this patch, and
>>> most of the split comes out just right now. However, there is one
>>> thing I'd like to pick on:
>>>
>>> decache_vcpus_on_cpu should be an arch callback, and rather than
>>> kvm_arch_vcpu_decache. There's no reason for s390 to grab locks and
>>> do the arch callback in a loop. The whole thing is nop for us, thus
>>> the whole thing should be a callback.
>>>
>>> I'd really like to see this changed before the patch gets merged.
>>>
>> Xiantao, can you address this?
>>
>
> Yes, adressed in attached patch. :)
>
Just to be sure: this is a replacement for your previous #3 patch, all
the rest remain unchanged?
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-11-14 15:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-14 5:43 [PATCH] 3/5 Using kvm arch support instead of kvm_x86_ops Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDC94FACA-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-14 11:53 ` Carsten Otte
[not found] ` <473AE1A9.3010501-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-11-14 12:35 ` [PATCH] 3/5 Using kvm arch support instead ofkvm_x86_ops Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDC94FBF9-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-14 13:04 ` Carsten Otte
2007-11-14 12:45 ` Zhang, Xiantao
2007-11-14 13:35 ` [PATCH] 3/5 Using kvm arch support instead of kvm_x86_ops Avi Kivity
[not found] ` <473AF995.9000006-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-14 15:20 ` Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDC94FC27-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-14 15:25 ` Avi Kivity [this message]
[not found] ` <473B1368.9000304-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-11-14 15:30 ` [PATCH] 3/5 Using kvm arch support instead ofkvm_x86_ops Zhang, Xiantao
[not found] ` <42DFA526FC41B1429CE7279EF83C6BDC94FC29-wq7ZOvIWXbMAbVU2wMM1CrfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2007-11-14 16:05 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473B1368.9000304@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=hollisb-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=xiantao.zhang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox