From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: Fix accounting of interrupts during guest execution on s390 Date: Wed, 14 Nov 2007 18:04:39 +0200 Message-ID: <473B1C97.2010007@qumranet.com> References: <200711141632.37004.borntraeger@de.ibm.com> <20071114153651.GA3441@elte.hu> <200711141647.45810.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , Laurent Vivier To: Christian Borntraeger Return-path: In-Reply-To: <200711141647.45810.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Christian Borntraeger wrote: > Am Mittwoch, 14. November 2007 schrieb Ingo Molnar: > >> * Christian Borntraeger wrote: >> >> >>> Avi, Ingo, Laurent, >>> >>> what do you think about the following patch? >>> >> fine to me. I guess this should mostly be a NOP to KVM, right? >> > > Yes, currently kvm on x86 has interrupts disabled during vmx and svm. So > in_interrupt should be always false on x86. > But isn't account_system_time() called via the timer tick interrupt, and never directly from kvm? So in_interrupt() would always be true. The sequence, as I understand it, is: - disable interrupts - set PF_VCPU - switch to guest - exit guest due to timer tick - enable interrupts - dispatch timer tick - account_system_time() With the fine-grained accounting ppc and s390 have, this is different. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/