From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [ kvm-Bugs-1829614 ] ioapic.c:214: error: 'dest_LowestPrio' undeclared Date: Wed, 14 Nov 2007 18:32:46 +0200 Message-ID: <473B232E.2030508@qumranet.com> References: <20071114163110.GA13605@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Carlo Marcelo Arenas Belon Return-path: In-Reply-To: <20071114163110.GA13605@tapir> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carlo Marcelo Arenas Belon wrote: > On Sat, Nov 10, 2007 at 11:19:01AM -0800, SourceForge.net wrote: > >> Bugs item #1829614, was opened at 2007-11-10 21:19 >> Message generated for change (Tracker Item Submitted) made by Item Submitter >> You can respond by visiting: >> https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1829614&group_id=180599 >> > > had to revert the fix for these which was committed here : > > http://git.kernel.org/?p=virt/kvm/kvm-userspace.git;a=commitdiff;h=5d6ea6b370ff9aae1dd7671b71e89351749fbeee#patch1 > > because (at least in gentoo and vanilla kernels) all those are defined in > as part of the following enum : > > 64 enum ioapic_irq_destination_types { > 65 dest_Fixed = 0, > 66 dest_LowestPrio = 1, > 67 dest_SMI = 2, > 68 dest__reserved_1 = 3, > 69 dest_NMI = 4, > 70 dest_INIT = 5, > 71 dest__reserved_2 = 6, > 72 dest_ExtINT = 7 > 73 }; > > leading to invalid code after the preprocessor run as shown by the following > compilation error : > > In file included from > kvm-52/kernel/ioapic.c:43: > include/asm/io_apic.h:65: error: expected identifier before numeric constant > make[2]: *** > [kernel/ioapic.o] Error 1 > make[1]: *** > [kernel] Error 2 > > Ouch. Committed the following: commit 26e6e6a8681f1041b61fccdf2fdf2aacb88cee36 Author: Avi Kivity Date: Wed Nov 14 18:31:51 2007 +0200 kvm: external module: include asm/io_apic.h before redefining its symbols diff --git a/kernel/external-module-compat.h b/kernel/external-module-compat.h index 29917e4..59964a1 100644 --- a/kernel/external-module-compat.h +++ b/kernel/external-module-compat.h @@ -517,6 +517,9 @@ out: #endif /* Some kernels don't make dest_* available with some configs. */ + +#include + #ifndef dest_Fixed #define dest_Fixed 0 #define dest_LowestPrio 1 (END) -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/