[ kvm-Bugs-1829614 ] ioapic.c:214: error: 'dest_LowestPrio' undeclared

[ kvm-Bugs-1829614 ] ioapic.c:214: error: 'dest_LowestPrio' undeclared

[SourceForge.net]

Bugs item #1829614, was opened at 2007-11-10 21:19
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1829614&group_id=180599

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: mike k (mike_kol)
Assigned to: Nobody/Anonymous (nobody)
Summary: ioapic.c:214: error: 'dest_LowestPrio' undeclared

Initial Comment:
At least kvm-45 and kvm-51 fails to build on my system.
Version 33 compiles fine.
Relevant log:
  CC [M]  /mnt/big_things/CRUX/main_ports/work/kvm/src/kvm-51/kernel/ioapic.o
/mnt/big_things/CRUX/main_ports/work/kvm/src/kvm-51/kernel/ioapic.c: In function 'ioapic_deliver':
/mnt/big_things/CRUX/main_ports/work/kvm/src/kvm-51/kernel/ioapic.c:214: error: 'dest_LowestPrio' undeclared (first use in this function)
/mnt/big_things/CRUX/main_ports/work/kvm/src/kvm-51/kernel/ioapic.c:214: error: (Each undeclared identifier is reported only once
/mnt/big_things/CRUX/main_ports/work/kvm/src/kvm-51/kernel/ioapic.c:214: error: for each function it appears in.)
/mnt/big_things/CRUX/main_ports/work/kvm/src/kvm-51/kernel/ioapic.c:225: error: 'dest_Fixed' undeclared (first use in this function)
make[3]: *** [/mnt/big_things/CRUX/main_ports/work/kvm/src/kvm-51/kernel/ioapic.o] Error 1
make[2]: *** [_module_/mnt/big_things/CRUX/main_ports/work/kvm/src/kvm-51/kernel] Error 2
make[2]: Leaving directory `/mnt/big_things/CRUX/kernel/linux-2.6.23.1'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/mnt/big_things/CRUX/main_ports/work/kvm/src/kvm-51/kernel'
make: *** [kernel] Error 2

# uname -a
2.6.23.1-mk31 #1 Sat Oct 20 14:24:45 EEST 2007 i686 i686 i386 GNU/Linux

# gcc-3.4 -v
Reading specs from /usr/lib/gcc/i686-pc-linux-gnu/3.4.6/specs
Configured with: ../gcc-3.4.6/configure --prefix=/usr --libexecdir=/usr/lib --program-suffix=-3.4 --enable-languages=c,c++,objc --enable-threads=posix --enable-__cxa_atexit --enable-clocale=gnu --enable-shared --disable-nls --with-x=no
Thread model: posix
gcc version 3.4.6

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1829614&group_id=180599

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [ kvm-Bugs-1829614 ] ioapic.c:214: error: 'dest_LowestPrio' undeclared

[Carlo Marcelo Arenas Belon]

On Sat, Nov 10, 2007 at 11:19:01AM -0800, SourceForge.net wrote:
> Bugs item #1829614, was opened at 2007-11-10 21:19
> Message generated for change (Tracker Item Submitted) made by Item Submitter
> You can respond by visiting: 
> https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1829614&group_id=180599

had to revert the fix for these which was committed here :

http://git.kernel.org/?p=virt/kvm/kvm-userspace.git;a=commitdiff;h=5d6ea6b370ff9aae1dd7671b71e89351749fbeee#patch1

because (at least in gentoo and vanilla kernels) all those are defined in
<asm/io_apic.h> as part of the following enum :

64 enum ioapic_irq_destination_types {
65         dest_Fixed = 0,
66         dest_LowestPrio = 1,
67         dest_SMI = 2,
68         dest__reserved_1 = 3,
69         dest_NMI = 4,
70         dest_INIT = 5,
71         dest__reserved_2 = 6,
72         dest_ExtINT = 7
73 };

leading to invalid code after the preprocessor run as shown by the following
compilation error :

In file included from
kvm-52/kernel/ioapic.c:43:
include/asm/io_apic.h:65: error: expected identifier before numeric constant
make[2]: ***
[kernel/ioapic.o] Error 1
make[1]: ***
[kernel] Error 2

Carlo

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

Re: [ kvm-Bugs-1829614 ] ioapic.c:214: error: 'dest_LowestPrio' undeclared

[Avi Kivity]

Carlo Marcelo Arenas Belon wrote:
> On Sat, Nov 10, 2007 at 11:19:01AM -0800, SourceForge.net wrote:
>   
>> Bugs item #1829614, was opened at 2007-11-10 21:19
>> Message generated for change (Tracker Item Submitted) made by Item Submitter
>> You can respond by visiting: 
>> https://sourceforge.net/tracker/?func=detail&atid=893831&aid=1829614&group_id=180599
>>     
>
> had to revert the fix for these which was committed here :
>
> http://git.kernel.org/?p=virt/kvm/kvm-userspace.git;a=commitdiff;h=5d6ea6b370ff9aae1dd7671b71e89351749fbeee#patch1
>
> because (at least in gentoo and vanilla kernels) all those are defined in
> <asm/io_apic.h> as part of the following enum :
>
> 64 enum ioapic_irq_destination_types {
> 65         dest_Fixed = 0,
> 66         dest_LowestPrio = 1,
> 67         dest_SMI = 2,
> 68         dest__reserved_1 = 3,
> 69         dest_NMI = 4,
> 70         dest_INIT = 5,
> 71         dest__reserved_2 = 6,
> 72         dest_ExtINT = 7
> 73 };
>
> leading to invalid code after the preprocessor run as shown by the following
> compilation error :
>
> In file included from
> kvm-52/kernel/ioapic.c:43:
> include/asm/io_apic.h:65: error: expected identifier before numeric constant
> make[2]: ***
> [kernel/ioapic.o] Error 1
> make[1]: ***
> [kernel] Error 2
>
>   

Ouch.  Committed the following:

commit 26e6e6a8681f1041b61fccdf2fdf2aacb88cee36
Author: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Date:   Wed Nov 14 18:31:51 2007 +0200

    kvm: external module: include asm/io_apic.h before redefining its 
symbols

diff --git a/kernel/external-module-compat.h 
b/kernel/external-module-compat.h
index 29917e4..59964a1 100644
--- a/kernel/external-module-compat.h
+++ b/kernel/external-module-compat.h
@@ -517,6 +517,9 @@ out:
 #endif

 /* Some kernels don't make dest_* available with some configs. */
+
+#include <asm/io_apic.h>
+
 #ifndef dest_Fixed
 #define dest_Fixed        0
 #define dest_LowestPrio   1
(END)                        


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/