Re: [Disscussion] Moving x86 code out of kvm.h

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Zhang, Xiantao wrote:
> Jerone Young wrote:
>   
>> This is a continuation of a conversation I have been having with Izik
>> Eidus on IRC today.
>>
>> I plan on moving x86 code out of kvm.h and into kvm-x86.h. kvm-x86.h
>> would then include kvm.h and would be included by files like svm.c
>> instead of kvm.h.
>>     
>
> I assume you are talking about include/linux/kvm.h, since userspace
> doesn't need drivers/kvm/kvm.h. 
>
> For driver/kvm/kvm.h,  I have a proposal before in mailing list.  In my
> proposal, we can split x86-specific code of kvm.h into current x86.h,
> and make code in kvm.h as common. Then, we rename kvm.h to kvm_comm.h,
> and also rename x86.h to kvm-x86.h, and meantime kvm-x86.h would include
> kvm_comm.h. 
> At compile time, we can make symbol link for changing kvm-x86.h to
> kvm.h.  So, it should be more portable, because different archs can
> define its kvm-$arch.h to hold its arch-specific code. 
>   

I prefer not to have dynamic symlinks, it's too tricky.

What's wrong with just the first part, x86.h which includes kvm.h?  
x86.c will include x86.h, and arch neutral files will include kvm.h.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/