Re: [PATCH v2] kvm: Fix accounting of interrupts during guest execution on s390

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Christian Borntraeger wrote:
> Am Donnerstag, 15. November 2007 schrieb Avi Kivity:
>   
>>> +	if ((p->flags & PF_VCPU) && (irq_count() - hardirq_offset == 0))
>>>       
> [...]
>   
>> What's irq_count()?  Is it defined to ignore the timer tick?  Or is that 
>> hardirq_offset?
>>     
>
> hardirq_offset is used to ignore the timer tick.
> irq_count is defined in hardirq.h:
>
> #define irq_count()     (preempt_count() & (HARDIRQ_MASK | SOFTIRQ_MASK))
>
> So irq_count() - hardirq_offset is not zero if a hardirq or a softirq is
> running. By subtracting hardirq_offset (the timer tick sets it to
> HARDIRQ_OFFSET) it also makes sure, that the timer tick does not count as
> hardirq.
> This seems to do the trick.
>
>   

Ah, ok.  Thanks for the explanation.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/