From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] [RESEND] qemu: simulate edge-triggered interrupt in master PIC for time-drift-fix Date: Sun, 18 Nov 2007 12:43:56 +0200 Message-ID: <4740176C.2070609@qumranet.com> References: <20071118052519.GA28227@tapir> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Carlo Marcelo Arenas Belon Return-path: In-Reply-To: <20071118052519.GA28227@tapir> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Carlo Marcelo Arenas Belon wrote: > The following patch fixes 1a483ef4040ed380bf69d684783d06a617073256 so that the > parent PIC pointer is used to send the edge irq0 instead of the PIC pair and > that is an incompatible pointer type as reported in : > > qemu/hw/i8259.c: In function `pic_read_irq': > qemu/hw/i8259.c:248: > warning: passing arg 1 of `pic_set_irq1' from incompatible pointer type > qemu/hw/i8259.c:249: > warning: passing arg 1 of `pic_set_irq1' from incompatible pointer type > > the code is equivalent as the compiler packs the PicState2 struct for s in a > way that makes "s" and "&s->pics[0]" point to the same address. > > Applied, thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/