From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Roel Kluin <12o3l-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [PATCH] check shadow_pte == NULL in FNAME(page_fault); drivers/kvm/paging_tmpl.h
Date: Sun, 18 Nov 2007 13:02:25 +0200 [thread overview]
Message-ID: <47401BC1.7080403@qumranet.com> (raw)
In-Reply-To: <473E03AC.3000403-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
Roel Kluin wrote:
> #------------------------------------------------------------------------------#
> in function FNAME(page_fault), drivers/kvm/paging_tmpl.h, line 450, (linus' git)
>
> I think a check is in place. I am not sure whether this is how it should be
> done, nor was the patch below tested. So please review.
> --
> The u64 pointer shadow_pte is initialized by the function FNAME(fetch), but
> FNAME(fetch) can return NULL,
>
>
It cannot; if walker->pte is not present we bail out sooner. See the
check immediately before the call to FNAME(fetch).
The check in FNAME(fetch) is dead code.
--
error compiling committee.c: too many arguments to function
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
prev parent reply other threads:[~2007-11-18 11:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 20:55 [PATCH] check shadow_pte == NULL in FNAME(page_fault); drivers/kvm/paging_tmpl.h Roel Kluin
[not found] ` <473E03AC.3000403-IWqWACnzNjzz+pZb47iToQ@public.gmane.org>
2007-11-18 11:02 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47401BC1.7080403@qumranet.com \
--to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
--cc=12o3l-IWqWACnzNjzz+pZb47iToQ@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox