From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] check shadow_pte == NULL in FNAME(page_fault); drivers/kvm/paging_tmpl.h Date: Sun, 18 Nov 2007 13:02:25 +0200 Message-ID: <47401BC1.7080403@qumranet.com> References: <473E03AC.3000403@tiscali.nl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Roel Kluin <12o3l-IWqWACnzNjzz+pZb47iToQ@public.gmane.org> Return-path: In-Reply-To: <473E03AC.3000403-IWqWACnzNjzz+pZb47iToQ@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Roel Kluin wrote: > #------------------------------------------------------------------------------# > in function FNAME(page_fault), drivers/kvm/paging_tmpl.h, line 450, (linus' git) > > I think a check is in place. I am not sure whether this is how it should be > done, nor was the patch below tested. So please review. > -- > The u64 pointer shadow_pte is initialized by the function FNAME(fetch), but > FNAME(fetch) can return NULL, > > It cannot; if walker->pte is not present we bail out sooner. See the check immediately before the call to FNAME(fetch). The check in FNAME(fetch) is dead code. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2005. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/